Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add addPrimaryKeyConstraint for AlterTableBuilder #639

Merged
merged 1 commit into from
Aug 9, 2023
Merged

Add addPrimaryKeyConstraint for AlterTableBuilder #639

merged 1 commit into from
Aug 9, 2023

Conversation

n7olkachev
Copy link
Contributor

@n7olkachev n7olkachev commented Aug 7, 2023 •
edited

Closes #636

@vercel
Copy link

vercel bot commented Aug 7, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
kysely ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 7, 2023 8:35pm

@n7olkachev n7olkachev mentioned this pull request Aug 7, 2023
Closed
@igalklebanov igalklebanov added enhancement New feature or request mysql Related to MySQL postgres Related to PostgreSQL api Related to library's API labels Aug 7, 2023
igalklebanov
igalklebanov approved these changes Aug 7, 2023
View reviewed changes
Copy link
Member

@igalklebanov igalklebanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🙏

LGTM! 🚀
left a minor comment..

test/node/src/schema.test.ts Outdated Show resolved Hide resolved
@koskimas
Copy link
Member

koskimas commented Aug 9, 2023

Thank you!

@koskimas koskimas merged commit db8999b into kysely-org:master Aug 9, 2023
4 checks passed
Gaspero pushed a commit to Gaspero/kysely that referenced this pull request Oct 2, 2023
@n7olkachev @Gaspero
add addPrimaryKeyConstraint for AlterTableBuilder (kysely-org#639)
cf06a5b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igalklebanov igalklebanov igalklebanov approved these changes

Assignees
No one assigned
Labels
api Related to library's API enhancement New feature or request mysql Related to MySQL postgres Related to PostgreSQL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Changing the primary key of existing tables
3 participants
@n7olkachev @koskimas @igalklebanov