Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loose typechecking on innerJoin/leftJoin comparisons #854

Open
thelinuxlich opened this issue Jan 22, 2024 · 2 comments
Open

Loose typechecking on innerJoin/leftJoin comparisons #854

thelinuxlich opened this issue Jan 22, 2024 · 2 comments
Labels
bug Something isn't working typescript Related to Typescript

Comments

@thelinuxlich
Copy link

thelinuxlich commented Jan 22, 2024

This was a bit surprising, as it shows a type error correctly on where comparisons, see this simple example using branded types

https://kyse.link/?p=s&i=dabQfp4kuUal04VrkyR1

(updated the reproduction with whereRef and where)

@koskimas
Copy link
Member

whereRef also has the same loose type issue. You used where which compares the column to a value "u.id".

@thelinuxlich
Copy link
Author

Oh yeah, I always forget these two are separate, my bad, gonna update the example

@igalklebanov igalklebanov added typescript Related to Typescript bug Something isn't working labels Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working typescript Related to Typescript
Projects
None yet
Development

No branches or pull requests

3 participants