Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TODO: delete CreateExtractors logic in this library and use echo.CreateExtractors instead #7

Open
aldas opened this issue Jan 26, 2023 · 0 comments
Open

TODO: delete CreateExtractors logic in this library and use echo.CreateExtractors instead #7

aldas opened this issue Jan 26, 2023 · 0 comments
Assignees
@aldas

Comments

@aldas
Copy link
Contributor

aldas commented Jan 26, 2023 •
edited

I copy/pasted CreateExtractors logic from Echo core library here because it was made public in v4.10.0 but this library supports Echo versions v4.7.0+.

Lets wait some time (maybe until 2023 summer) and to reduce code duplication delete CreateExtractors logic in this library and use echo.CreateExtractors instead.

p.s. do not delete public method - make them use core. unforntunately I made them public
@aldas aldas self-assigned this Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aldas aldas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aldas