Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow escaping of colon in route path #1988

Merged
merged 1 commit into from Sep 19, 2021

Conversation

aldas
Copy link
Contributor

@aldas aldas commented Sep 16, 2021

allow escaping of colon in route path so Google Cloud API "custom methods" https://cloud.google.com/apis/design/custom_methods could be implemented (resolves #1987)

@codecov
Copy link

codecov bot commented Sep 16, 2021

Codecov Report

Merging #1988 (545191d) into master (f6b45f2) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1988   +/-   ##
=======================================
  Coverage   91.22%   91.23%           
=======================================
  Files          33       33           
  Lines        2884     2886    +2     
=======================================
+ Hits         2631     2633    +2     
  Misses        161      161           
  Partials       92       92           
Impacted Files Coverage Δ
router.go 95.72% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6b45f2...545191d. Read the comment docs.

@aldas aldas requested a review from pafuent September 17, 2021 19:39
Copy link
Contributor

@lammel lammel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, simple and effective.

@aldas aldas merged commit 9fc4672 into labstack:master Sep 19, 2021
@aldas aldas deleted the allow_colon_escaping_in_route_path branch January 8, 2022 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow escaped : char in route path
2 participants