From b83fae37e47a0c5353180ab675b9e87d0d8c1c09 Mon Sep 17 00:00:00 2001 From: yunnysunny Date: Sun, 3 Apr 2022 13:32:41 +0800 Subject: [PATCH 1/2] ci: trigger ci on push and pull request --- .github/workflows/ci.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index f85f00718..e662073f0 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -1,6 +1,5 @@ name: CI -on: - push: +on: [push, pull_request] env: SAUCE_USERNAME: shtylman-superagent From b2b330bfad8e71454817b4ddd7a37be492974a1b Mon Sep 17 00:00:00 2001 From: yunnysunny Date: Sun, 3 Apr 2022 13:37:02 +0800 Subject: [PATCH 2/2] ci: use secret env to hide the sauce config --- .github/workflows/ci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index e662073f0..87750e30e 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -2,8 +2,8 @@ name: CI on: [push, pull_request] env: - SAUCE_USERNAME: shtylman-superagent - SAUCE_ACCESS_KEY: 39a45464-cb1d-4b8d-aa1f-83c7c04fa673 + SAUCE_USERNAME: ${{ secrets.SAUCE_USERNAME }} + SAUCE_ACCESS_KEY: ${{ secrets.SAUCE_ACCESS_KEY }} jobs: test: