Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drain once is not good #1740

Open
ulisesbocchio opened this issue Sep 23, 2022 · 0 comments
Open

drain once is not good #1740

ulisesbocchio opened this issue Sep 23, 2022 · 0 comments

Comments

@ulisesbocchio
Copy link

this PR to address #1084 changed the re-emitter of drain to once... which is not good. Piping a large stream into a request hangs indefinitely because request only drains once. Listener should be on and cleaned up after close is emitted.
https://github.com/visionmedia/superagent/blob/29fd1f917a6cc78c9a2a9984269c06f8b4e63dcb/src/node/index.js#L821-L823
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ulisesbocchio