Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config loading over ConfigProviderInterface if available #11

Open
func0der opened this issue Apr 6, 2021 · 0 comments
Open

Config loading over ConfigProviderInterface if available #11

func0der opened this issue Apr 6, 2021 · 0 comments

Comments

@func0der
Copy link

func0der commented Apr 6, 2021

$configPath = $this->recurseTree($moduleClassPath);

This line of code requires every module to have a module.config.php lying around, even if the Module.php does provide the config already.

Since the Module class is already reflected to find the path for the module, why not just also check for the ConfigProviderInterface and get the config from there.
We could still get the config from module.config.php as a backup or vice versa to not break the current behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant