Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PatchKey uses ReplaceKey #2

Open
weierophinney opened this issue Dec 31, 2019 · 4 comments
Open

PatchKey uses ReplaceKey #2

weierophinney opened this issue Dec 31, 2019 · 4 comments

Comments

@weierophinney
Copy link
Contributor

The function patchKey does not actually patch a key. It uses replaceKey to do the heavy lifting:
https://github.com/zfcampus/zf-configuration/blob/master/src/ConfigResource.php#L118

I submit patchKey should read the current key and merge the arrays.


Originally posted by @TomHAnderson at zfcampus/zf-configuration#21

@weierophinney
Copy link
Contributor Author

This is still a big issue for zf-apigility-doctrine users because the query_create_filters and query_providers are all lost. These are a major source of security information for an app.

This issue was closed for 1.3.1 which was reverted to 1.3.2 and remains unfixed today. Will you please re-open this issue and prioritize it high.


Originally posted by @TomHAnderson at zfcampus/zf-configuration#21 (comment)

@weierophinney
Copy link
Contributor Author

@TomHAnderson Please review #378. The reason it was reverted is because it breaks the admin. The original author of #25 does not feel it can be accomplished without a BC break, and, right now, that's a no-go.

If you can propose a solution that does not break the admin, we will certainly review it.

I'm re-opening, so we don't lose track of it, but it's not something we are going to prioritize at this time, due to the BC implications.


Originally posted by @weierophinney at zfcampus/zf-configuration#21 (comment)

@weierophinney
Copy link
Contributor Author

Seeing this fixed is a priority to me so I'll dig through it to see about fixing the library and fixing the admin. I (should) have down time in a couple weeks in SF to investigate.


Originally posted by @TomHAnderson at zfcampus/zf-configuration#21 (comment)

@TomHAnderson
Copy link

I submit that the move to Laminas is worthy of a BC break to fix this issue.

This affects every API I create/d with Apigility and is a major inconvenience. Every API module configuration which requires query_create_filters and query_providers must be bifurcated into a security.config.php and module.config.php then the configs merged in the Module.php.

This is the biggest bug in API Tools and Laminas. I implore you to make this change now before it continues to be something that can only be fixed with a BC break and the issue is once again buried.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants