Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 8.1 support #94

Closed
wants to merge 7 commits into from
Closed

PHP 8.1 support #94

wants to merge 7 commits into from

Conversation

chris1312
Copy link

PHP 8.1 support

@Ocramius Ocramius added the Enhancement New feature or request label Feb 10, 2022
Ocramius
Ocramius requested changes Feb 10, 2022
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs composer.lock update

@froschdesign froschdesign linked an issue Feb 10, 2022 that may be closed by this pull request
PHP 8.1 support #93
Open
@froschdesign froschdesign added this to In progress in PHP 8.1 via automation Feb 10, 2022
froschdesign
froschdesign reviewed Feb 24, 2022
View reviewed changes
composer.json Outdated Show resolved Hide resolved
froschdesign
froschdesign requested changes Feb 24, 2022
View reviewed changes
composer.json Outdated Show resolved Hide resolved
chris1312 and others added 5 commits February 24, 2022 11:59
@chris1312
Update composer.json
19af2cb 
Signed-off-by: kristijonas bulzgis <kristijonas.bulzgis@visma.com>
@chris1312 @yet-another-peter-at-castor
Update composer.json
1883027 
Co-authored-by: Piotr Zygmuntowicz <97437683+yet-another-peter-at-castor@users.noreply.github.com>
Signed-off-by: kristijonas bulzgis <kristijonas.bulzgis@visma.com>
Add composer.lock updates
93bc514 
Signed-off-by: kristijonas bulzgis <kristijonas.bulzgis@visma.com>
Just updates for testing sign-off feature.
dc9867b 
Signed-off-by: kristijonas bulzgis <kristijonas.bulzgis@visma.com>
@chris1312 @froschdesign
Update composer.json
516c64e 
Co-authored-by: Frank Brückner <info@froschdesignstudio.de>
Signed-off-by: kristijonas bulzgis <kristijonas.bulzgis@visma.com>
@Ocramius Ocramius added this to the 1.6.0 milestone Feb 24, 2022
Ocramius
Ocramius requested changes Feb 24, 2022
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like CI is in shambles here 😬

@chris1312
Copy link
Author

So, for PHP 8.1, the current obstacles are upgrades of these modules:

  • laminas-api-tools/api-tools-mvc-auth
  • laminas-api-tools/api-tools-oauth2

Also, I suggest dropping support for PHP 7.3, and avoid committing composer.lock to the repository (composer.lock can be generated automatically during the CI run).

@Ocramius
Copy link
Member

avoid committing composer.lock to the repository

We will commit composer.lock to all our repositories, to guarantee reproducible builds.

We are currently adding @renovatebot to all our repos to keep it fresh on a daily basis, and eagerly discover incompatibilities.

Totally okay with dropping php 7.3: we don't support EOL php versions anyway

Drop support for 7.3
d2bd8fe 
Signed-off-by: kristijonas bulzgis <kristijonas.bulzgis@visma.com>
Ocramius
Ocramius requested changes Feb 24, 2022
View reviewed changes
composer.lock Outdated Show resolved Hide resolved
Drop support for 7.3
88eea12 
Signed-off-by: kristijonas bulzgis <kristijonas.bulzgis@visma.com>
@Ocramius Ocramius mentioned this pull request Mar 25, 2022
Open
@Ocramius
Copy link
Member

Ocramius commented Jun 6, 2022

Moved to #95 meanwhile, thanks for all your help though, still adding this to release notes for accrediting it :-)

@Ocramius Ocramius self-assigned this Jun 6, 2022
@Ocramius Ocramius closed this Jun 6, 2022
PHP 8.1 automation moved this from In progress to Done Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius Ocramius requested changes

@yet-another-peter-at-castor yet-another-peter-at-castor yet-another-peter-at-castor left review comments

@froschdesign froschdesign froschdesign requested changes

Assignees

@Ocramius Ocramius

Labels
Enhancement New feature or request
Projects
PHP 8.1
Done
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.

PHP 8.1 support
4 participants
@chris1312 @Ocramius @froschdesign @yet-another-peter-at-castor