Feature alpha5 #12
Merged
Feature alpha5 #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geerteltink
added a commit
that referenced
this pull request
Jan 6, 2020
geerteltink
added a commit
that referenced
this pull request
Jan 6, 2020
geerteltink
added a commit
that referenced
this pull request
Jan 6, 2020
geerteltink
pushed a commit
that referenced
this pull request
May 4, 2020
Fixes #12 The sniff is not working properly in case we are overridding the method and changing default value of parameters. Please see: * zendframework/zend-coding-standard#12 * squizlabs/PHP_CodeSniffer#519
geerteltink
added a commit
that referenced
this pull request
May 4, 2020
…idingMethod-sniff Fix #12 - disable UselessOverridingMethod sniff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Preparing for a 2.0 release. Due to encountered issues some dependencies have to be locked until fixed. Maybe it's better to keep them locked anyway to make sure the coding standard is working as expected at all time. Without locking 3rd party sniffs this cannot be guaranteed.