Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove contradicting rule for file header comment #36

Merged
merged 1 commit into from Sep 8, 2020
Merged

Remove contradicting rule for file header comment #36

merged 1 commit into from Sep 8, 2020

Conversation

geerteltink
Copy link
Member

@geerteltink geerteltink commented Sep 7, 2020 •
edited

This MR removes the contradicting rules for the file header comment.

Q A
Bugfix yes

Description

Fixes #35

@geerteltink
Fix: Exclude DeclareStrictTypes as it conflicts with PSR12.Files.File…
137a921 
…Header

Signed-off-by: Geert Eltink <dev@elt.ink>
@geerteltink geerteltink added the Bug Something isn't working label Sep 7, 2020
@geerteltink geerteltink changed the base branch from master to develop September 7, 2020 20:10
@geerteltink geerteltink changed the title Fix contradicting rules for file header comment Remove contradicting rule for file header comment Sep 7, 2020
@geerteltink geerteltink added this to the 2.1.0 milestone Sep 7, 2020
@geerteltink geerteltink self-assigned this Sep 8, 2020
@geerteltink geerteltink merged commit 0a3a28a into laminas:develop Sep 8, 2020
@geerteltink geerteltink deleted the fix/declaration branch September 8, 2020 06:35
@geerteltink geerteltink mentioned this pull request Sep 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@geerteltink geerteltink

Labels
Bug Something isn't working
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.

Contradicting rules for file header comment
1 participant
@geerteltink