Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: loosen typehint rules #54

Merged
merged 1 commit into from Oct 26, 2020
Merged

fix: loosen typehint rules #54

merged 1 commit into from Oct 26, 2020

Conversation

geerteltink
Copy link
Member

This PR loosens the typehint rules a bit more for BC.

Added missing rule:

  • SlevomatCodingStandard.TypeHints.PropertyTypeHintSpacing

Excluded rules:

  • SlevomatCodingStandard.TypeHints.PropertyTypeHint.MissingNativeTypeHint
  • SlevomatCodingStandard.TypeHints.PropertyTypeHint.MissingTraversableTypeHintSpecification
  • SlevomatCodingStandard.TypeHints.ReturnTypeHint.MissingTraversableTypeHintSpecification
  • SlevomatCodingStandard.TypeHints.UselessConstantTypeHint

@geerteltink
fix: loosen typehint rules
b3aacb8 
Signed-off-by: Geert Eltink <geert.eltink@gmail.com>
@geerteltink geerteltink added the Bug Something isn't working label Oct 26, 2020
@geerteltink geerteltink added this to the 2.1.4 milestone Oct 26, 2020
@geerteltink geerteltink self-assigned this Oct 26, 2020
@geerteltink geerteltink merged commit 3391984 into laminas:2.1.x Oct 26, 2020
@geerteltink geerteltink deleted the fix/loosen-typehint-rules branch October 26, 2020 07:30
@github-actions github-actions bot mentioned this pull request Oct 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@geerteltink geerteltink

Labels
Bug Something isn't working
Projects
None yet
Milestone
2.1.4
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@geerteltink