Remove laminas-zendframework-bridge. #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laminas-coding-standard is used by other laminas projects. Although it's mostly a dev dependency, it's still probably a good idea to remove the zendframework bridge, to avoid having more complicated autoloading than needed. Signed-off-by: Danack <Danack@basereality.com>
Danack
force-pushed
the
remove-zend-bridge
branch
from
873db4a
to
0a96c2c
Compare
|
@geerteltink I actually think this might be fine to do in next minor. Extending this library is generally unusual, and we likely should have done it when we released v2, which happened after the migration anyways. |
geerteltink
approved these changes
May 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
laminas-coding-standard is used by other laminas projects. Although it's mostly a dev dependency, it's still probably a good idea to remove the zendframework bridge, to avoid having more complicated autoloading than needed.
Description
Tell us about why this change is necessary:
Although it's mostly a dev dependency, it's still probably a good idea to remove the zendframework bridge, to avoid having more complicated autoloading than needed.
See laminas/laminas-escaper#11 (comment)
How do you reproduce it?
composer update.
What was the previous behavior?
Has the zend bridge.
Not to have the bridge.