Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AbstractPluginManager::get has parameter name mismatch with ContainerInterface::get #89

Closed
Slamdunk opened this issue May 26, 2021 · 5 comments · Fixed by #179
Closed
Labels
Bug Something isn't working
Milestone

Comments

@Slamdunk
Copy link
Contributor

Found in laminas/laminas-form#121 (comment)

As of PHP 8 named parameters, \Laminas\ServiceManager\AbstractPluginManager::get(name) should be renamed to \Laminas\ServiceManager\AbstractPluginManager::get(id)

@Slamdunk Slamdunk added the Bug Something isn't working label May 26, 2021
@Ocramius
Copy link
Member

To clarify, this is a parameter name mismatch is not within the library, but against psr/container.

@mattkershaw-CAP
Copy link

This mismatch also means the IDE is unable to infer the type of the returned service.

@Ocramius
Copy link
Member

Ocramius commented Dec 6, 2022

@mattkershaw-CAP send a patch 😁

@boesing boesing added this to the 4.0.0 milestone Jan 22, 2023
@boesing
Copy link
Member

boesing commented Jan 22, 2023

imho can be update with v4 as changing argument names in times of named arguments is problematic.

@boesing
Copy link
Member

boesing commented Mar 5, 2023

Might be fixed with #179

@boesing boesing linked a pull request Mar 5, 2023 that will close this issue
5 tasks
@boesing boesing closed this as completed May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants