Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows scripts do not delegate to MainGenericRunner #15220

Closed
bishabosha opened this issue May 18, 2022 · 7 comments
Closed

Windows scripts do not delegate to MainGenericRunner #15220

bishabosha opened this issue May 18, 2022 · 7 comments

Comments

@bishabosha
Copy link
Member

bishabosha commented May 18, 2022

if we want a unified experience across platforms then the windows batch scripts should replicate the bash scripts for other platforms, i.e. delegate to the MainGenericRunner

i.e. see how https://github.com/lampepfl/dotty/blob/main/dist/bin/scala does minimal preprocessing of the arguments before delegating to the class dotty.tools.MainGenericRunner

@michelou I have assigned you since you made the original scripts, but feel free let us know if you do not want to.

@michelou
Copy link
Collaborator

@bishabosha I saw your changes to dist/bin/scala yesterday; I will update the batch file dist/bin/scala.bat.

.

@michelou
Copy link
Collaborator

@bishabosha With PR 15275 (backport to the 3.1.3 branch) this issue now affects both upcoming 3.1 and 3.2 releases.

@bishabosha bishabosha modified the milestones: 3.2.0-RC1, 3.1.3 May 24, 2022
@bishabosha
Copy link
Member Author

@michelou do you have time to work on this? or would you like some help?

@michelou
Copy link
Collaborator

@bishabosha Work is in progress.
I have changes in the 4 batch files (common.bat, scala.bat, scalac.bat and scaladoc.bat).

Two remarks regarding the changes :

  • batch files are now shorter (positive effect).
  • changes are quite large, so more testing is needed.

Do you know what are the release deadlines for 3.1.3 and 3.2.0-RC1 ?

@griggt
Copy link
Collaborator

griggt commented May 24, 2022

Do you know what are the release deadlines for 3.1.3

3.1.3-RC4 was released to Maven Central earlier today: https://repo1.maven.org/maven2/org/scala-lang/scala3-compiler_3/3.1.3-RC4/

see #15282

@Kordyjan
Copy link
Contributor

Do you know what are the release deadlines for 3.1.3 and 3.2.0-RC1 ?

As of now, the date is June 1st.

@prolativ
Copy link
Contributor

Fixed via #15325

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants