Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interactive: fix contextOfPath for Template #12783

Merged
merged 1 commit into from Feb 11, 2022

Conversation

dos65
Copy link
Collaborator

@dos65 dos65 commented Jun 10, 2021

Without this fix, in case if input path: List[Tree] starts from Template.constr tree contextOfPath ignores parent trees and returns non-completed Context value.

Copy link
Contributor

@odersky odersky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logically, I'd expect to use outer if constr contains nested and ctx if parents or self contains nested. I might be wrong, but it's worth trying.

@odersky odersky assigned dos65 and unassigned nicolasstucki Jun 24, 2021
@bishabosha
Copy link
Member

Hi @dos65, will you be able to try out the change?

@dos65
Copy link
Collaborator Author

dos65 commented Jul 8, 2021

@bishabosha yes - will change it. Sorry, I forgot about this PR.

@dos65 dos65 force-pushed the interactive_context_of_path_fix branch from abb0eab to 0ff94b2 Compare July 16, 2021 15:07
@dos65
Copy link
Collaborator Author

dos65 commented Jul 16, 2021

Logically, I'd expect to use outer if constr contains nested and ctx if parents or self contains nested. I might be wrong, but it's worth trying.

@odersky
I checked it one more time. For constr/parents/self it should return outer. I added completion tests cases that is fixed by this change.

@nicolasstucki nicolasstucki removed their request for review January 13, 2022 12:34
@dos65 dos65 force-pushed the interactive_context_of_path_fix branch from 0ff94b2 to 0296150 Compare February 8, 2022 10:00
@dos65 dos65 requested a review from odersky February 8, 2022 10:04
@dos65
Copy link
Collaborator Author

dos65 commented Feb 8, 2022

@odersky I rebased commit. Could we merge it?

@bishabosha bishabosha self-requested a review February 8, 2022 21:03
@bishabosha bishabosha assigned bishabosha and unassigned dos65 Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants