Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept supplementary characters #13136

Merged
merged 1 commit into from Mar 14, 2022
Merged

Accept supplementary characters #13136

merged 1 commit into from Mar 14, 2022

Conversation

som-snytt
Copy link
Contributor

Forward port scala/scala#9687

Fixes #13045

@som-snytt som-snytt force-pushed the forward/supplementary branch 3 times, most recently from 1dc80cf to 7dd2a52 Compare July 23, 2021 15:41
@som-snytt
Copy link
Contributor Author

som-snytt commented Jul 24, 2021 •
edited

Includes mild getLitChar refactor from scala 2 PR and adds unicode arrow deprecation.

Will fix the f-interpolator format strings once f-interpolator is fixed.

@som-snytt som-snytt marked this pull request as ready for review July 24, 2021 13:38
dwijnand
dwijnand approved these changes Jul 28, 2021
View reviewed changes
Copy link
Member

@dwijnand dwijnand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but it's not my area of expertise so I'll merge it in a few days to see if there are other reviewers.

@dwijnand dwijnand assigned som-snytt and unassigned dwijnand Jul 28, 2021
@som-snytt som-snytt mentioned this pull request Aug 1, 2021
Closed
@rtyley rtyley mentioned this pull request Aug 10, 2021
Merged
@som-snytt som-snytt closed this Sep 3, 2021
@som-snytt som-snytt reopened this Dec 16, 2021
@som-snytt
Copy link
Contributor Author

Rebased, but let's wait a few more days.

@odersky
Copy link
Contributor

odersky commented Mar 13, 2022

LGTM, but it's not my area of expertise so I'll merge it in a few days to see if there are other reviewers.

It's been a few days 😉 Merge now?

@SethTisue SethTisue merged commit d2ebd75 into scala:main Mar 14, 2022
@som-snytt som-snytt deleted the forward/supplementary branch March 14, 2022 02:56
@michelou
Copy link
Collaborator

@som-snytt Nice refactoring (charEscape, uEscape, octalEscape) ! 👍

@Kordyjan Kordyjan added this to the 3.1.3 milestone Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwijnand dwijnand dwijnand approved these changes

Assignees

@som-snytt som-snytt

Labels
None yet
Projects
None yet
Milestone
3.1.3
Development

Successfully merging this pull request may close these issues.

Scala3 should support Unicode supplementary characters
6 participants
@som-snytt @odersky @michelou @dwijnand @SethTisue @Kordyjan