Expand `compiletime.ops` #13400

soronpo · 2021-08-26T17:55:11Z

This PR expands compiletime.ops as follows:

Adds ops.string.{Length, Substring, Matches}
Adds ops.int.NumberOfLeadingZeros
Adds ops.long as equivalent to ops.int, but for Long operations
Adds ops.float and ops.double
Adds ops.any.IsConst
Deprecates ops.int.ToString (from 3.2.x) and moves it to ops.any.ToString
Fixes constant termrefs types not being recognized (e.g.: one.type + two.type, where one and two are final vals).

MaximeKjaer

In general, this looks good to me! But seeing that I'm not currently very active in the day-to-day Dotty development, I'm adding @OlivierBlanvillain as a reviewer, so that we have the approval of one of the core maintainers too.

I do also have a higher-level question about Strings in particular: should we aim to have full support of all the methods in java.lang.String? We're missing methods like charAt, startsWith, etc. Some of these methods also take objects, such as format which takes a String or a Locale for the locale parameter. We can't support Locale, but we could support String.

compiler/src/dotty/tools/dotc/core/Types.scala

library/src/scala/compiletime/ops/int.scala

tests/neg/singleton-ops-int.scala

compiler/src/dotty/tools/dotc/core/Types.scala

library/src/scala/compiletime/ops/string.scala

compiler/src/dotty/tools/dotc/core/Types.scala

library/src/scala/compiletime/ops/string.scala

soronpo · 2021-09-06T21:34:47Z

I do also have a higher-level question about Strings in particular: should we aim to have full support of all the methods in java.lang.String? We're missing methods like charAt, startsWith, etc. Some of these methods also take objects, such as format which takes a String or a Locale for the locale parameter. We can't support Locale, but we could support String.

I currently do not support Char. Seems redundant to me, and can always be converted to an operation on a string in length of 1. So CharAt is redundant if we have Substring. Additionally, Matches covers more use cases, and users can create their own StartsWith etc. using type alias compositions. I think this PR covers most common use cases, and if we implement the SIP https://contributors.scala-lang.org/t/pre-sip-custom-dependent-operation-types/5236 , then the rest can be supported rather easily.

soronpo · 2021-09-06T21:43:51Z

@smarter since we are currently in RC1, can we still get this in 3.1.0 if there will be RC2?

smarter · 2021-09-06T21:45:24Z

No, only fixes to regressions are backported into the release branch.

smarter · 2021-09-06T21:46:56Z

Though the added operations could be added in 3.1.1 as @experimental (but ops.int.ToString cannot be deprecated until there's a non-experimental replacement).

soronpo · 2021-09-06T21:46:56Z

OK, then the deprecation for int.ToString needs to change to 3.1.1. I'll handle that as well.

mbovel · 2021-10-01T13:23:29Z

I am very interested by this PR, I was going to add the same fix for getting the underlying types of termrefs 😃

What is the status? Could we merge this soon or are there any blockers?

smarter · 2021-10-01T13:34:16Z

It needs to be reviewed and the added definitions need to be marked @experimental so we can drop the "needs-minor-release" label.

soronpo · 2021-10-01T14:43:59Z

I am very interested by this PR, I was going to add the same fix for getting the underlying types of termrefs 😃

What is the status? Could we merge this soon or are there any blockers?

I'll try to complete this soon.

cquiroz · 2021-10-25T21:35:31Z

This PR would be very useful to me. I'd need it to cross build coulomb to dotty
erikerlandson/coulomb#130

… termref type not being considered. fix check file more ops wip Added ops.float and ops.double

Update MiMaFilters.scala Update MiMaFilters.scala

Main changes: * Apply common protection against wrong number of arguments. * Exception in an operation is converted into a type error.

…e and known

soronpo · 2021-10-26T11:44:45Z

Ready for review @OlivierBlanvillain

compiler/src/dotty/tools/dotc/core/Types.scala

tests/neg/singleton-ops-any.scala

johnynek · 2021-10-28T17:53:41Z

BTW: I think this PR really brings up a weakness of match types: we shouldn't need to have a PR in the compiler to implement these functions.

It seems like if metaprogramming could be combined with match types, then you could implement these functions in your own code. That seems like it would be a promising area.

soronpo · 2021-10-28T23:21:04Z

BTW: I think this PR really brings up a weakness of match types: we shouldn't need to have a PR in the compiler to implement these functions.

It seems like if metaprogramming could be combined with match types, then you could implement these functions in your own code. That seems like it would be a promising area.

Hence, this Pre-SIP: https://contributors.scala-lang.org/t/pre-sip-custom-dependent-operation-types/5236/14

OlivierBlanvillain

LGTM!

OlivierBlanvillain · 2021-11-17T14:43:16Z

tests/neg/singleton-ops-int.scala

@@ -70,8 +73,6 @@ object Test {

  val t48: ToString[213] = "213"
  val t49: ToString[-1] = "-1"
-  val t50: ToString[0] = "-0" // error
-  val t51: ToString[200] = "100" // error


What's wrong with that test?

What's wrong with that test?

Nothing was wrong. At first I wanted to remove all int.ToString tests because it was deprecated, but then I decided not to remove the tests until it was removed completely. So perhaps I forgot to bring these tests back as well. I could change the commit, but I don't think it's a big deal.

library/src/scala/compiletime/ops/long.scala

OlivierBlanvillain · 2021-11-17T16:42:52Z

BTW: I think this PR really brings up a weakness of match types: we shouldn't need to have a PR in the compiler to implement these functions.

@johnynek IMO it's perfectly normal to require compiler support for type-level operations on primitive types. In the long term, the goal should be to be on par with term-level operations on primitives. If somebody is interested in working on a follow-up PR to add support for Char and other String operations, it's very likely to get in!

smarter · 2021-12-02T14:24:44Z

library/src/scala/compiletime/ops/int.scala

@@ -181,4 +183,47 @@ object int:
   *  ```
   *  @syntax markdown
   */
+  @deprecated("Use compiletime.ops.any.ToString instead.","3.2.0")


@soronpo I think this warning will be shown even before 3.2.0 is released which means users will have to choose between a deprecated and an experimental definition, could you comment out the deprecated annotation for now?

@smarter why would it show before? The version is specified. Is there a bug in @deprecated? If so, we should fix this instead.

soronpo requested a review from MaximeKjaer August 27, 2021 00:04

soronpo force-pushed the ct_ops_expansion branch from 6d7c825 to 9570a88 Compare August 27, 2021 01:23

MaximeKjaer reviewed Sep 6, 2021

View reviewed changes

MaximeKjaer requested a review from OlivierBlanvillain September 6, 2021 16:55

smarter added the needs-minor-release This PR cannot be merged until the next minor release label Sep 6, 2021

mbovel assigned OlivierBlanvillain Oct 1, 2021

cquiroz mentioned this pull request Oct 25, 2021

scala 3 roadmap erikerlandson/coulomb#130

Closed

soronpo added 6 commits October 26, 2021 06:25

Adds compiletime.ops.{long, float, double}, adds other ops, and fixes…

f213eff

… termref type not being considered. fix check file more ops wip Added ops.float and ops.double

add experimental annotation to added type operations and update MiMa

6792387

Update MiMaFilters.scala Update MiMaFilters.scala

Deprecation of int.ToString will only start from 3.2.0

32043aa

Address review comments.

d433ce8

Main changes: * Apply common protection against wrong number of arguments. * Exception in an operation is converted into a type error.

improve any.IsConst to be evaluated only if its argument is concret…

e8d00f8

…e and known

Fix documentation errors. Remove redundant long.ToString

762d90e

soronpo force-pushed the ct_ops_expansion branch from ea00474 to 762d90e Compare October 26, 2021 10:36

soronpo removed the needs-minor-release This PR cannot be merged until the next minor release label Oct 26, 2021

johnynek reviewed Oct 28, 2021

View reviewed changes

compiler/src/dotty/tools/dotc/core/Types.scala Show resolved Hide resolved

johnynek reviewed Oct 28, 2021

View reviewed changes

tests/neg/singleton-ops-any.scala Show resolved Hide resolved

Merge branch 'master' into ct_ops_expansion

75a3df2

OlivierBlanvillain approved these changes Nov 17, 2021

View reviewed changes

Fix code formatting

3083cae

OlivierBlanvillain force-pushed the ct_ops_expansion branch from 9594465 to 3083cae Compare November 17, 2021 16:43

soronpo added 2 commits November 22, 2021 12:04

Add missing colon

3769562

Add missing colon

18c23f4

OlivierBlanvillain merged commit e7f7e19 into scala:master Nov 29, 2021

smarter reviewed Dec 2, 2021

View reviewed changes

soronpo mentioned this pull request Jan 5, 2022

Remove deprecation of compiletime.ops.int.ToString #14217

Merged

This was referenced Jan 14, 2022

Fix #7512: Normalize type arguments before instantiation #14259

Merged

Add compiletime benchmarks and fix performance regression #14273

Merged

OlivierBlanvillain mentioned this pull request Feb 8, 2022

Add compiletime.ops.string.CharAt #14431

Merged

Kordyjan added this to the 3.1.2 milestone Aug 2, 2023

unkarjedy mentioned this pull request Aug 4, 2023

scala.compiletime.ops.long.S doesn't work #18342

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Expand `compiletime.ops` #13400

Expand `compiletime.ops` #13400

soronpo commented Aug 26, 2021 •

edited

MaximeKjaer left a comment

soronpo commented Sep 6, 2021

soronpo commented Sep 6, 2021

smarter commented Sep 6, 2021

smarter commented Sep 6, 2021

soronpo commented Sep 6, 2021

mbovel commented Oct 1, 2021

smarter commented Oct 1, 2021

soronpo commented Oct 1, 2021

cquiroz commented Oct 25, 2021

soronpo commented Oct 26, 2021

johnynek commented Oct 28, 2021

soronpo commented Oct 28, 2021

OlivierBlanvillain left a comment

OlivierBlanvillain Nov 17, 2021

soronpo Nov 22, 2021 •

edited

OlivierBlanvillain commented Nov 17, 2021 •

edited

smarter Dec 2, 2021 •

edited

soronpo Dec 4, 2021

Expand compiletime.ops #13400

Expand compiletime.ops #13400

Conversation

soronpo commented Aug 26, 2021 • edited

MaximeKjaer left a comment

Choose a reason for hiding this comment

soronpo commented Sep 6, 2021

soronpo commented Sep 6, 2021

smarter commented Sep 6, 2021

smarter commented Sep 6, 2021

soronpo commented Sep 6, 2021

mbovel commented Oct 1, 2021

smarter commented Oct 1, 2021

soronpo commented Oct 1, 2021

cquiroz commented Oct 25, 2021

soronpo commented Oct 26, 2021

johnynek commented Oct 28, 2021

soronpo commented Oct 28, 2021

OlivierBlanvillain left a comment

Choose a reason for hiding this comment

OlivierBlanvillain Nov 17, 2021

Choose a reason for hiding this comment

soronpo Nov 22, 2021 • edited

Choose a reason for hiding this comment

OlivierBlanvillain commented Nov 17, 2021 • edited

smarter Dec 2, 2021 • edited

Choose a reason for hiding this comment

soronpo Dec 4, 2021

Choose a reason for hiding this comment

Expand `compiletime.ops` #13400

Expand `compiletime.ops` #13400

soronpo commented Aug 26, 2021 •

edited

soronpo Nov 22, 2021 •

edited

OlivierBlanvillain commented Nov 17, 2021 •

edited

smarter Dec 2, 2021 •

edited