Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collective extensions is sensitive to EOF #13432

Merged
merged 1 commit into from Oct 14, 2021
Merged

Conversation

som-snytt
Copy link
Contributor

This allows REPL to input extensions.

Fixes #9374

This allows REPL to input extensions.
@som-snytt
Copy link
Contributor Author

Supersedes #13375

This just inlines the call to extMethod and checks EOF.

Review by @dos65

Copy link
Collaborator

@dos65 dos65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@som-snytt
Copy link
Contributor Author

Also verified that empty extension at EOF errors correctly.

5 |
  |^
  |Extension without extension methods
1 error found

I haven't written a line counting program since I was a teenager, though I did fix some line bugs in Scala 2's Position, but I see the error is reported on a line after the last line in the file. That is with a terminal EOL, so really the "last line" is merely empty and does not itself end in EOL.

@som-snytt som-snytt closed this Sep 3, 2021
@dwijnand
Copy link
Member

dwijnand commented Sep 3, 2021

Any reason for closing this, @som-snytt?

@dwijnand dwijnand reopened this Oct 14, 2021
@dwijnand dwijnand merged commit ba43eb1 into scala:master Oct 14, 2021
@som-snytt som-snytt deleted the issue/9374 branch December 26, 2021 07:21
@Kordyjan Kordyjan added this to the 3.1.1 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support multiline collective extensions in REPL
5 participants