Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid shadowing of name 'name' #13442

Merged
merged 4 commits into from Nov 16, 2021
Merged

Avoid shadowing of name 'name' #13442

merged 4 commits into from Nov 16, 2021

Conversation

som-snytt
Copy link
Contributor

@som-snytt som-snytt commented Sep 2, 2021

Fixes #13440

@som-snytt
Copy link
Contributor Author

Reopen for rebase.

@som-snytt
Copy link
Contributor Author

As a refresher, HEAD says

-- [E040] Syntax Error: /tmp/i13440.scala:6:11 --------------------------------------------------------------------------------------------------
6 |  val s = s"$enum" // error
  |           ^
  |           '}' expected, but string literal found
-- Error: /tmp/i13440.scala:6:17 ----------------------------------------------------------------------------------------------------------------
6 |  val s = s"$enum" // error
  |                 ^
  |                 unclosed string literal
exception occurred while parser /tmp/i13440.scala
exception occurred while compiling /tmp/i13440.scala
java.lang.NullPointerException: Cannot invoke "dotty.tools.dotc.core.Names$SimpleName.length()" because the return value of "dotty.tools.dotc.parsing.Scanners$Scanner.name()" is null while compiling /tmp/i13440.scala
Exception in thread "main" java.lang.NullPointerException: Cannot invoke "dotty.tools.dotc.core.Names$SimpleName.length()" because the return value of "dotty.tools.dotc.parsing.Scanners$Scanner.name()" is null
        at dotty.tools.dotc.parsing.Scanners$Scanner.treatAsIdent(Scanners.scala:255)
        at dotty.tools.dotc.parsing.Scanners$Scanner.handleMigration(Scanners.scala:246)
        at dotty.tools.dotc.parsing.Scanners$Scanner.toToken(Scanners.scala:260)
        at dotty.tools.dotc.parsing.Scanners$ScannerCommon.finishNamed(Scanners.scala:146)
        at dotty.tools.dotc.parsing.Scanners$Scanner.getStringPart(Scanners.scala:1171)
        at dotty.tools.dotc.parsing.Scanners$Scanner.stringPart$1(Scanners.scala:786)
        at dotty.tools.dotc.parsing.Scanners$Scanner.fetchDoubleQuote$1(Scanners.scala:807)
        at dotty.tools.dotc.parsing.Scanners$Scanner.fetchToken(Scanners.scala:826)
        at dotty.tools.dotc.parsing.Scanners$Scanner.nextToken(Scanners.scala:343)
        at dotty.tools.dotc.parsing.Parsers$Parser.interpolatedString(Parsers.scala:1192)

@odersky
Copy link
Contributor

odersky commented Nov 8, 2021

Hi Tim, could you take a look at this? Thanks?

@griggt griggt merged commit b311b4e into scala:master Nov 16, 2021
@som-snytt
Copy link
Contributor Author

@griggt Thanks, Tom?

@som-snytt som-snytt deleted the issue/13440 branch November 17, 2021 02:36
@Kordyjan Kordyjan added this to the 3.1.2 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StringFormatter.showArg throws NullPointerException
4 participants