Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set correct source for generated TypeTrees #13465

Merged
merged 1 commit into from Sep 7, 2021
Merged

Set correct source for generated TypeTrees #13465

merged 1 commit into from Sep 7, 2021

Conversation

nicolasstucki
Copy link
Contributor

Fixes #13352

@nicolasstucki nicolasstucki marked this pull request as ready for review September 3, 2021 16:02
smarter
smarter approved these changes Sep 3, 2021
View reviewed changes
Copy link
Member

@smarter smarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does the TypeBoundsTree extractor also matches TypeTrees?

@nicolasstucki
Copy link
Contributor Author

nicolasstucki commented Sep 3, 2021 •
edited

Yes, if the tpd.TypeTree contains a TypeBound. See TypeBoundsTreeTypeTest.

@smarter
Copy link
Member

smarter commented Sep 3, 2021

But why do we need to support that in the reflection API when in the compiler we match on TypeTree instead if we need to? Just for convenience?

@nicolasstucki
Copy link
Contributor Author

But why do we need to support that in the reflection API when in the compiler we match on TypeTree instead if we need to? Just for convenience?

It was added for convenience based on user feedback.

@nicolasstucki
Copy link
Contributor Author

Rebased to ensure no conflicts

@nicolasstucki nicolasstucki merged commit 842323a into scala:master Sep 7, 2021
@nicolasstucki nicolasstucki deleted the fix-#13352 branch September 7, 2021 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smarter smarter smarter approved these changes

Assignees

@smarter smarter

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Getting Position of Tree fails execution
2 participants
@nicolasstucki @smarter