Do not remove accessors to early #13484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Accessors that are added to packages were removed to early from `accessedBy`. This resulted in a new symbol beeing entered for the same accessor. Fixes scala#13476
Make sure that `AccessProxies.accessedBy` can be GCed.
nicolasstucki
force-pushed
the
fix-#13476
branch
2 times, most recently
from
f5da9fc
to
0853b3d
Compare
Make sure that `AccessProxies.accessedBy` can be GCed.
nicolasstucki
force-pushed
the
fix-#13476
branch
from
0853b3d
to
1c0bf3f
Compare
odersky
approved these changes
Sep 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accessors that are added to packages were removed to early from
accessedBy.This resulted in a new symbol beeing entered for the same accessor.
Fixes #13476