Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #13487: Unification check in deriving is incorrect #13489

Merged
merged 1 commit into from Sep 27, 2021
Merged

Fix #13487: Unification check in deriving is incorrect #13489

merged 1 commit into from Sep 27, 2021

Conversation

Kordyjan
Copy link
Contributor

@Kordyjan Kordyjan commented Sep 8, 2021

Fixes #13487
Change suggested by @sugakandrey

bishabosha
bishabosha approved these changes Sep 27, 2021
View reviewed changes
Copy link
Member

@bishabosha bishabosha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this actually makes the doc for deriveSingleParameter correct

@Kordyjan Kordyjan merged commit ee8d2ab into scala:master Sep 27, 2021
@Kordyjan Kordyjan deleted the i13487 branch September 27, 2021 09:22
@bishabosha bishabosha removed their assignment Sep 27, 2021
@Kordyjan Kordyjan added this to the 3.1.1 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bishabosha bishabosha bishabosha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.1.1
Development

Successfully merging this pull request may close these issues.

Unification check in deriving is incorrect
2 participants
@Kordyjan @bishabosha