Don't count constructors in allMembers #13505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This caused a crash for Metals with the following stacktrace ``` Caused by: dotty.tools.dotc.core.TypeError: Toplevel definition <init> is defined in /Users/odersky/workspace/dotty/compiler/target/scala-3.1.0-RC1/classes/dotty/tools/dotc/util/LinearMap$package.class and also in /Users/odersky/workspace/dotty/compiler/target/scala-3.1.0-RC1/classes/dotty/tools/dotc/util/LinearSet$package.class One of these files should be removed from the classpath. at dotty.tools.dotc.core.SymDenotations$PackageClassDenotation.dropStale$1(SymDenotations.scala:2439) at dotty.tools.dotc.core.SymDenotations$PackageClassDenotation.recur$1(SymDenotations.scala:2403) at dotty.tools.dotc.core.SymDenotations$PackageClassDenotation.computeMembersNamed(SymDenotations.scala:2459) at dotty.tools.dotc.core.SymDenotations$ClassDenotation.membersNamed(SymDenotations.scala:2012) at dotty.tools.dotc.core.SymDenotations$ClassDenotation.findMember(SymDenotations.scala:2063) at dotty.tools.dotc.core.Types$Type.go$1(Types.scala:683) at dotty.tools.dotc.core.Types$Type.goThis$1(Types.scala:807) at dotty.tools.dotc.core.Types$Type.go$1(Types.scala:700) at dotty.tools.dotc.core.Types$Type.findMember(Types.scala:870) at dotty.tools.dotc.core.Types$Type.memberBasedOnFlags(Types.scala:666) at dotty.tools.dotc.core.Types$Type.member(Types.scala:650) at dotty.tools.dotc.core.Types$Type.allMembers$$anonfun$1(Types.scala:1011) ``` The problem arises when calling allMembers on a package with multiple package objects. These will all have a constructor, and the constructors fail the dropStale test. There is not really a good way to pick one constructor over another, so it's better to drop constructors in allMembers.
tgodzik
approved these changes
Sep 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This caused a crash for Metals with the following stacktrace
The problem arises when calling allMembers on a package with multiple package objects. These
will all have a constructor, and the constructors fail the dropStale test. There is not really
a good way to pick one constructor over another, so it's better to drop constructors in allMembers.