Fix #13518: Scala.js: fix primitive + string when the string is a TermRef. #13537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a TermRef. Sometimes, the argument string's `tpe` can be a `TermRef`, in which case it is not directly a ref to `StringClass`. That was triggering the assertion. The assertions and the calls to `makePrimitiveBox` have actually not been needed for a long time. The IR supports the arguments to a `String_+` operator to be of any type. So we fix the issue by removing all of that and directly emitting the `String_+`.
nicolasstucki
approved these changes
Sep 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes, the argument string's
tpecan be aTermRef, in which case it is not directly a ref toStringClass. That was triggering the assertion.The assertions and the calls to
makePrimitiveBoxhave actually not been needed for a long time. The IR supports the arguments to aString_+operator to be of any type. So we fix the issue by removing all of that and directly emitting theString_+.