Set the correct owner when quote making inlinable #13547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
fixx-#13546
branch
from
5ed0845
to
fd34d99
Compare
odersky
requested changes
Oct 9, 2021
| PrepareInlineable.makeInlineable(tree) | ||
| def quoteOwner(sym: Symbol): Symbol = | ||
| if sym.owner.isClass then sym else quoteOwner(sym.owner) | ||
| inContext(ctx.withOwner(quoteOwner(ctx.owner))) { |
There was a problem hiding this comment.
You don't need quoteOwner.
ctx.owner.enclosingClasswill work.
There was a problem hiding this comment.
That will not work. We need the symbol of the method in that class. We are skipping local owners. Do we have something for that? I could not find it. I could add it to SymDenotation.
odersky
approved these changes
Oct 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13546