Scaladoc: UI/UX Changes #13566
Merged
Scaladoc: UI/UX Changes #13566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pikinier20
requested review from
romanowski,
TheElectronWill,
BarkingBad and
KacperFKorban
|
Is alignment intended? |
|
@BarkingBad No, it's not. It's probably broken due to the |
|
Missing class icons? Also I feel it uncomfortable to click directly on the text for "leafs" in navigation like |
|
Maybe golden color for annotations? |
pikinier20
force-pushed
the
scaladoc/change-dark-theme
branch
from
557b6c8
to
bea83c5
Compare
BarkingBad
approved these changes
Sep 20, 2021
|
Looks for the most part good. Notice that the scroll bar disappeared at some point in the past, and while I understand it causes problems, I also think it's important for it to be present. That's not related to these changes though. |
pikinier20
force-pushed
the
scaladoc/change-dark-theme
branch
from
bea83c5
to
f9276c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed elements:
@Katrix I tag you because you always were involved in UI/UX part of Scaladoc.
I'm going to post there link to example documentation as soon as it's generated.