Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #13491: Add regression test #13585

Merged
merged 1 commit into from Sep 27, 2021

Conversation

OlivierBlanvillain
Copy link
Contributor

No description provided.

Copy link
Member

@smarter smarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM although it might be useful to identify which PR fixed this to backport it to 3.1.0 since it fixes a regression.

@@ -37,6 +37,7 @@ i9999.scala
12093.scala
9757.scala
9890.scala
13491.scala
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How come?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pickling test failure can be minimized to the following:

object Test {
  type M[X] = X match { case Int => String }
  def a: Any { type Out = M[Int] } = a
}

The failure comes from the refinement type, which is printed as
scala.Any{Out = scala.String} before pickling, and
scala.Any{Out = Test.M[scala.Int]} after pickling...

I'll open a new issue from that minimization.

@OlivierBlanvillain
Copy link
Contributor Author

OlivierBlanvillain commented Sep 27, 2021

Breakage bisected to #12773, fix bisected to #13253.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants