Check that right hand sides of implicit defs don't loop (directly) #13589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kordyjan
approved these changes
Sep 28, 2021
There was a problem hiding this comment.
It looks correct.
I was concerned that we are checking for the direct recurrsion not only in the implicit defs but also in given instances with context parameters. However, I wasn't able to find any example of code that would give a false positive warning. So as far as I can tell it is a proper fix.
smarter
reviewed
Sep 28, 2021
| if !t.symbol.is(Lazy) then checkNotLooping(t.rhs) | ||
| case _ => | ||
|
|
||
| if sym.isOneOf(GivenOrImplicit) then |
There was a problem hiding this comment.
Any reason to not extend this to non-implicit definitions too? It would help with extension methods too for example: #9880
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13542