Ignore StaleSymbol exceptions when testing whether dependencies shoul… #13594
Conversation
…d be ignored Fixes scala#13532 A question is whether the catch should be in `ignoreDependency` in the SBT dependency extractor or in `isAbsent` itself. I put it in `ignoreDependency` for now in order not to hide possible stale symbol errors since isAbsent is called quite often.
|
Catching in ignoreDependency seems safer indeed, but I don't have a good grasp on how suspended compilation works: why do we get a stale symbol at all here? |
|
The stale symbol errors involve constructor proxies. I believe it's because we are generating them later on demand that the normal symbol update mechanisms don't always work. I am not sure about the precise details and don't have time to dig into it more. In the case of suspended computation it looks like it's the two phases that systematically follow all symbol links in usages that hit the stale symbol error. I verified that a program that calls a constructor proxy directly, but uses neither extract option, compiles correctly. @bishabosha Can you check that the updated semanticdb expect files are reasonable? |
compiler/src/dotty/tools/dotc/semanticdb/ExtractSemanticDB.scala
Outdated
Show resolved
Hide resolved
…d be ignored
Fixes #13532
A question is whether the catch should be in
ignoreDependencyin the SBT dependencyextractor or in
isAbsentitself. I put it inignoreDependencyfor now in ordernot to hide possible stale symbol errors since isAbsent is called quite often.