Fix #13495: Break completion cycles #13596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
reviewed
Sep 27, 2021
| @@ -1611,7 +1611,7 @@ object SymDenotations { | |||
| case _ => false | |||
|
|
|||
| if owner.isClass then | |||
| for c <- owner.info.decls.toList if maybeChild(c) do | |||
| for c <- owner.info.decls.toList if maybeChild(c) && (c.isClass || c.is(EnumVal)) do | |||
There was a problem hiding this comment.
This duplicates similar checks done in maybeChild, this can probably be avoided by tweaking maybeChild a bit.
OlivierBlanvillain
force-pushed
the
fix-13495
branch
from
4936fee
to
c13ecbd
Compare
smarter
approved these changes
Sep 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.