Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize prototype before decomposing as a function #13651

Merged
merged 1 commit into from Oct 6, 2021

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Oct 1, 2021

Fixes #13526

@odersky
Copy link
Contributor Author

odersky commented Oct 1, 2021

Looks like the requests CB project now fails for all new PRs. What could be the cause of this?

@odersky
Copy link
Contributor Author

odersky commented Oct 1, 2021

Here's the error:

[error] -- [E069] Syntax Error: /Users/odersky/workspace/dotty/library/src/scala/IArray.scala:13:7 
[error] 13 |object IArray:
[error]    |       ^
[error]    |object IArray cannot have the same name as object IArray in package scala -- cannot define object member with the same name as a object member in self reference _.
[error]    |(Note: this can be resolved by using another name)
[error] -- [E069] Syntax Error: /Users/odersky/workspace/dotty/library/src/scala/IArray.scala:13:7 
[error] 13 |object IArray:
[error]    |       ^
[error]    |object IArray cannot have the same name as object IArray in package scala -- cannot define object member with the same name as a object member in self reference _.
[error]    |(Note: this can be resolved by using another name)
[warn] three warnings found

This does very much look like a mis-configured test. Should we disable requests for now?

@griggt
Copy link
Collaborator

griggt commented Oct 1, 2021

Did the compilation of requests actually fail with that error? I just see a bunch of timeouts during the tests which looks as if the httpbin.org service was offline (the requests test suite seems to depend on this external service)

https://github.com/lampepfl/dotty/runs/3769019088#step:8:2614

 X requests.RequestTests.matchingMethodWorks 25670ms 
  requests.TimeoutException: Request to http://httpbin.org/put timed out. (readTimeout: 10000, connectTimout: 10000)

@odersky
Copy link
Contributor Author

odersky commented Oct 1, 2021

@griggt The IArray problem was what I saw when I ran it locally. So probably that's because I ran it with a non-empty classpath. Good to know what the real reason was, and hopefully it gets fixed soon.

@griggt
Copy link
Collaborator

griggt commented Oct 1, 2021

I restarted the CI workflow, it's green now.

@OlivierBlanvillain OlivierBlanvillain merged commit 40a1f44 into scala:master Oct 6, 2021
@OlivierBlanvillain OlivierBlanvillain deleted the fix-13526 branch October 6, 2021 15:44
@Kordyjan Kordyjan added this to the 3.1.1 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot infer type of tupled arguments
4 participants