Fix parents of tuple classes #13659
Merged
Fix parents of tuple classes #13659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
requested changes
Oct 4, 2021
| @@ -349,7 +349,11 @@ object TypeOps: | |||
| val doms = dominators(commonBaseClasses, Nil) | |||
| def baseTp(cls: ClassSymbol): Type = | |||
| tp.baseType(cls).mapReduceOr(identity)(mergeRefinedOrApplied) | |||
| doms.map(baseTp).reduceLeft(AndType.apply) | |||
| def meet(tp1: Type, tp2: Type) = | |||
| if !tp1.exists then tp2 | |||
There was a problem hiding this comment.
I don't understand why this is needed, we do:
val commonBaseClasses = tp.mapReduceOr(_.baseClasses)(intersect)(btw, how is this different from tp.baseClasses ?)
So I would expect tp.baseType on any of the common base classes to exist, but in fact the base classes of Tuple1[(Axis, Int)] | ((Axis, Int), (Axis, Int)) contains Product2, even though Tuple1 does not extend Product2, so I think there's a bug in how we compute base classes for unions, either here or in OrType#baseClasses.
There was a problem hiding this comment.
(btw, how is this different from tp.baseClasses ?)
Turns out it's different for Null. Since Null is also outside the inheritance hierarchy.
We inserted the :* class not in the correct place, so the linearizations of Tuple1..Tuple22 were messed up.
smarter
reviewed
Oct 5, 2021
smarter
approved these changes
Oct 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13435