Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't lose paramSyms when unpickling from Scala 2 #13665

Merged
merged 1 commit into from Oct 4, 2021
Merged

Don't lose paramSyms when unpickling from Scala 2 #13665

merged 1 commit into from Oct 4, 2021

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Oct 3, 2021

We could lose them for curried methods since the nested method type was copied
in case there was a depencency on a parameter of the first method type.

Fixes #13238

@odersky
Copy link
Contributor Author

odersky commented Oct 3, 2021 •
edited

I verified that it works if foo_1.scala is compiled with Scala 2.13. But I don't have enough knowledge and time to write a test for that. Does somebody else know how to do that? I.e. compile foo_1 with Scala 2.13, then boom_2 with Scala 3.1.

@odersky odersky requested a review from smarter October 3, 2021 19:32
@odersky @smarter
Don't lose paramSyms when unpickling from Scala 2
5fdbea8 
We could lose them for curried methods since the nested method type was copied
in case there was a depencency on a parameter of the first method type.

Fixes scala#13238
@smarter smarter enabled auto-merge October 4, 2021 15:07
@smarter smarter merged commit 1dda803 into scala:master Oct 4, 2021
@smarter smarter deleted the fix-13238 branch October 4, 2021 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smarter smarter smarter approved these changes

Assignees

@smarter smarter

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@odersky @smarter