New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scaladoc: Fix bugs found while setting up cats #13705
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only missing bits are tests for docs for package objects
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK
@@ -169,6 +169,7 @@ object Scaladoc: | |||
CommentSyntax.default | |||
} | |||
} | |||
val legacySourceLinkList = if legacySourceLink.get.nonEmpty then List(legacySourceLink.get) else Nil |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
val legacySourceLinkList = if legacySourceLink.get.nonEmpty then List(legacySourceLink.get) else Nil |
@@ -208,7 +209,7 @@ object Scaladoc: | |||
projectLogo.nonDefault, | |||
projectFooter.nonDefault, | |||
parseSyntax, | |||
sourceLinks.get, | |||
sourceLinks.get ++ legacySourceLinkList, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sourceLinks.get ++ legacySourceLinkList, | |
sourceLinks.get ++ Option(legacySourceLinkList.get).filter(_.nonEmpty), |
No description provided.