Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add init and last methods to NonEmptyTuple #13735

Merged
merged 8 commits into from Oct 13, 2021

Conversation

danicheg
Copy link
Contributor

init and last methods on tuples are very useful. In Scala 2 shapeless provide them for users. So it'd be great to have those methods in Scala 3 as well.
I'm open to any remarks and would be glad for suggestions on this.

library/src/scala/Tuple.scala Show resolved Hide resolved
library/src/scala/Tuple.scala Outdated Show resolved Hide resolved
project/Build.scala Outdated Show resolved Hide resolved
library/src/scala/Tuple.scala Outdated Show resolved Hide resolved
library/src/scala/Tuple.scala Outdated Show resolved Hide resolved
Copy link
Member

@smarter smarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@smarter smarter merged commit 3b5ff7a into scala:master Oct 13, 2021
@danicheg danicheg deleted the tuple-init-last branch October 13, 2021 21:29
danicheg added a commit to danicheg/dotty that referenced this pull request Oct 21, 2021
olsdavis pushed a commit to olsdavis/dotty that referenced this pull request Apr 4, 2022
@Kordyjan Kordyjan added this to the 3.1.1 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants