Widen qualifier skolems #13748
Merged
Widen qualifier skolems #13748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
reviewed
Oct 18, 2021
| @@ -1777,7 +1777,7 @@ class QuotesImpl private (using val ctx: Context) extends Quotes, QuoteUnpickler | |||
|
|
|||
| given NamedTypeMethods: NamedTypeMethods with | |||
| extension (self: NamedType) | |||
| def qualifier: TypeRepr = self.prefix | |||
| def qualifier: TypeRepr = self.prefix.widenSkolem | |||
There was a problem hiding this comment.
Should all reflection APIs that return possible skolems be changed to call widenSkolem? For example, x.prefix in TermRef.unapply and TypeRef.unapply could both return skolems. IMO, this is too easy to get wrong and we should instead handle skolems by exposing their parent trait SingletonType in the reflection API.
There was a problem hiding this comment.
Not sure if that would be a backwards compatible change.
anatoliykmetyuk
approved these changes
Oct 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13422