Warning for infinite recursive lazy vals #13749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Tom Grigg <griggt@users.noreply.github.com> Co-authored-by: Nicolas Stucki <nicolasstucki@users.noreply.github.com> Co-authored-by: Timothée Andres <timothee.andres@epfl.ch>
dwijnand
approved these changes
Oct 14, 2021
dwijnand
reviewed
Oct 15, 2021
|
The scripted test change seems correct. I'm not sure what the original intent of |
dwijnand
reviewed
Oct 18, 2021
|
|
||
| def firstDigitIsEven(n: Int): Boolean = if n % 10 == n then n % 2 == 0 else firstDigitIsEven(n / 10) | ||
|
|
||
| lazy val simple4: String = if firstDigitIsEven(22) then this.simple4 else "a" // error |
There was a problem hiding this comment.
Deja-vu, then: this shouldn't error, because it's only conditionally recursive, which we bias to not warning (IIRC). I don't understand why this is passing CI.
There was a problem hiding this comment.
We only check the condition:
case If(cond, _, _) =>
checkNotLooping(cond)
Is this erroring as a consequence of being a lazy val?
There was a problem hiding this comment.
no there's no error, it's my bad, I forgot to put ok there, testCompilation was indeed failing
I've pushed in the fix now.
dwijnand
approved these changes
Oct 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13011
Part of the issue spree
Co-authored-by: Tom Grigg griggt@users.noreply.github.com
Co-authored-by: Nicolas Stucki nicolasstucki@users.noreply.github.com
Co-authored-by: Timothée Andres timothee.andres@epfl.ch