Add annotations to semanticdb #13818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanishiking
reviewed
Oct 26, 2021
compiler/src/dotty/tools/dotc/semanticdb/ExtractSemanticDB.scala
Outdated
Show resolved
Hide resolved
tgodzik
force-pushed
the
add-annotations
branch
3 times, most recently
from
7246f49
to
7b7dbd0
Compare
Previously, it was not possible to find if a given method was for example annotated with @main, which will be useful for run/debug code lenses. Now, they should be correctly saved. The only issue seems to be `@specialized` which is currently producing empty type, anone knows what is going on?
tgodzik
force-pushed
the
add-annotations
branch
from
7b7dbd0
to
c4bcba4
Compare
bishabosha
reviewed
Oct 27, 2021
| @@ -95,6 +95,10 @@ object Scala3: | |||
| val kind = s.symbolKind(symkinds) | |||
| val sname = sym.symbolName | |||
| val signature = s.info.toSemanticSig(s) | |||
| val symbolAnnotations = s.annotations.collect{ | |||
| case annot if annot.symbol != defn.BodyAnnot && annot.symbol != defn.ChildAnnot => | |||
| Annotation(annot.symbol.typeRef.toSemanticType(annot.symbol)) | |||
There was a problem hiding this comment.
what if the annotation has type parameters? like @throws[java.io.IOException]
There was a problem hiding this comment.
Ach, that didn't work. I added a test case and switched how we get the type in the last commit.
bishabosha
reviewed
Oct 27, 2021
| @@ -97,7 +97,7 @@ object Scala3: | |||
| val signature = s.info.toSemanticSig(s) | |||
| val symbolAnnotations = s.annotations.collect{ | |||
| case annot if annot.symbol != defn.BodyAnnot && annot.symbol != defn.ChildAnnot => | |||
| Annotation(annot.symbol.typeRef.toSemanticType(annot.symbol)) | |||
| Annotation(annot.tree.typeOpt.toSemanticType(annot.symbol)) | |||
There was a problem hiding this comment.
if the tree has NoType then should we skip adding an annotation? Although as .tree is a tpd.Tree you should be able to call .tpe instead of .typeOpt without any issue
There was a problem hiding this comment.
Fixed! Using tpe instead
tgodzik
force-pushed
the
add-annotations
branch
from
e1eeec3
to
8fa8c36
Compare
bishabosha
approved these changes
Oct 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, it was not possible to find if a given method was for example annotated with @main, which will be useful for run/debug code lenses. Now, they should be correctly saved.
The only issue seems to be
@specializedwhich is currently producing empty type, anone knows what is going on?CC @tanishiking