Fix missing code-completion on standalone annotations #13831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prolativ
reviewed
Oct 27, 2021
|
I created a separate PR for the other part of the issue since it's not really related #13834 |
Co-authored-by: Stefan Pavikevik <spavikevik@users.noreply.github.com> Co-authored-by: Tomasz Godzik <tgodzik@users.noreply.github.com> Co-authored-by: Anatolii Kmetiuk <anatoliykmetyuk@gmail.com>
ghostbuster91
force-pushed
the
fix-13624
branch
from
f824994
to
eef5d76
Compare
prolativ
approved these changes
Nov 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds missing code completion for standalone annotations.
In a REPL session:
The annotations themselves are a part of
Modifiersobject which is not a tree but rather a bag of different modifiers.The root cause of the issue was that parser was returning an empty tree which can't have (AFAIK) any modifiers attached.
We solved that, by returning annotations tree from the
Modifiersobject instead of an empty tree.Relates to #13624
The work on this PR was powered by 7th edition of issue-spree 馃帀
Co-authored-by: @spavikevik
Co-authored-by: @tgodzik
Co-authored-by: @anatoliykmetyuk