Navigate the AST within AnnotatedType and ImportType #13834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prolativ
reviewed
Oct 28, 2021
|
|
||
| @Test def i13624_annotType: Unit = | ||
| code"""|class MyAnnotation extends annotation.StaticAnnotation | ||
| |val x = 1: @MyAnnot${m1} |
There was a problem hiding this comment.
I'm wondering how this is going to work in some more complex cases:
- If the used annotation is not visible in the current scope e.g.
val x = 1: @Foo.MyAnnot${m1}
- If you chain more than one annotations, e.g.
1: @MyAnnotation1 @MyAnnot${m1}
or
type X = Int @MyAnnotation1 @MyAnnot${m1}
- If annotations are nested, e.g.
1: @MyAnnotation2("abc": @MyAnnot${m1})
Could you add some tests for that?
There was a problem hiding this comment.
Added! And surprisingly all of them work 😅
prolativ
approved these changes
Oct 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #13624
This is the second part of #13831