Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scaladoc: Add support for tables in wiki syntax #13933

Merged

Conversation

pikinier20
Copy link
Contributor

@pikinier20 pikinier20 commented Nov 12, 2021

closes #13868

image

The code for parsing tables is copied from Scaladoc 2 wiki parser so I don't think it needs a thorough review.
The support for tables was probably added after copying the parser to dotty.

Copy link
Member

@BarkingBad BarkingBad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, though we could add some JSoup test to prove that there are added th/td//tr elements

@pikinier20 pikinier20 merged commit f215817 into scala:master Nov 15, 2021
@pikinier20 pikinier20 deleted the scaladoc/comment-rendering-fix branch November 15, 2021 13:52
@Kordyjan Kordyjan added this to the 3.1.2 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Markdown in @ tags is not rendered properly by scaladoc
3 participants