Tighten product match logic in irrefutable check #13962
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids accidentally considering refutable name-based extractors as
irrefutable because they also happen to be a Product.
With this change some tests no longer go through the Typ to Prod rewrite
that occurs in
minus(a, b)
whena
is a Typ andb
is a Prod,leading to a Typ result. This renders in the counter-example as a
generic value type rather than a product, which we see in the warning
text changes in the tests.