Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid field/field clashes #14081

Merged
merged 1 commit into from Dec 17, 2021
Merged

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Dec 9, 2021

There needs to be a special alignment of planetary bodies to obtain two fields
that have different names for Dotty (one has a FieldName, the other a regular name),
but that still map to the same underlying name. This is now detected and resolved.

Fixes #13862

There needs to be a special alignment of planetary body to obtain two fields
that have different names for Dotty (one has a FieldName, the other a regular name),
but that still map to the same underlying name. This is now detected and resolved.

Fixes scala#13862
@anatoliykmetyuk
Copy link
Contributor

I rebased this on master while resolving the conflict in NameTags, the new name tag got value 38 instead of 35 due to 3ab18a9#diff-27ca3deb10059ac8c51d2e45b4844743a94f871584d59ea91707adb7109e7e4cR35.

Hope this is fine, /cc @odersky @smarter

@odersky
Copy link
Contributor Author

odersky commented Dec 17, 2021

@anatoliykmetyuk Yes, the change is fine. Thanks for the rebase!

@anatoliykmetyuk anatoliykmetyuk merged commit 6b7db02 into scala:master Dec 17, 2021
@anatoliykmetyuk anatoliykmetyuk deleted the fix-13862 branch December 17, 2021 14:10
@Kordyjan Kordyjan added this to the 3.1.2 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Identical parameter name in trait and extending class results in ClassFormatError
3 participants