Make outer references Java-synthetic #14084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
requested changes
Dec 9, 2021
tests/pos/i14083.scala
Outdated
| @@ -0,0 +1,3 @@ | |||
| class Outer { | |||
| class Inner | |||
| } | |||
There was a problem hiding this comment.
You can turn this into a run test with:
Suggested change
| } | |
| @main def Test = | |
| assert(classOf[Outer#Inner].getConstructors.head.getParameters.head.isSynthetic) |
There was a problem hiding this comment.
Ok. And we also want to check that the field is synthetic.
|
Tests fail, with logs not showing @smarter, @anatoliykmetyuk do you have an idea what could be wrong here? |
|
seems like the runners get auto-cancelled after 15 minutes? |
Fixes scala#14083 I verified manually that the puter accessors are now ACC_SYNHETIC. If someone wants to add a bytecode test, this would be good. I don't know how to make one.
This does not work yet, since the backend does not issue a ACC_SYNTHETIC for parameters labeled Artifact.
smarter
approved these changes
Dec 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14083
I verified manually that the puter accessors are now ACC_SYNTHETIC. If someone wants to add a bytecode test, this would be good. I don't know how to make one.