Fix derivedPolyProto to use the correct result type
#14148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method parameter was called `resultType` but inside the method we use `resType` which is the result type of the existing PolyProto instance, so TypeMaps never updated the result type of a PolyProto before. According to git blame, this typo was introduced when the class parameter was renamed back in 2015 in b5c3a28.
odersky
approved these changes
Dec 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method parameter was called
resultTypebut inside the method weuse
resTypewhich is the result type of the existing PolyProtoinstance, so TypeMaps never updated the result type of a PolyProto
before.
According to git blame, this typo was introduced when the class
parameter was renamed back in 2015 in
b5c3a28.
Fixes #14145.