Add special case to init checker to always allow certain methods #14352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olhotak
requested changes
Jan 26, 2022
liufengyun
reviewed
Jan 26, 2022
olhotak
requested changes
Feb 2, 2022
|
Nitpick: to keep the history clean, it's better to rebase instead of creating unnecessary merge commits. |
Xavientois
force-pushed
the
eq-ne-always-valid-init-check
branch
3 times, most recently
from
deb85b7
to
a3c21ae
Compare
olhotak
approved these changes
Feb 2, 2022
liufengyun
approved these changes
Feb 2, 2022
Closes scala#14275 - Treats mehtods `ne`, `eq`, `isInstanceOf`, and `asInstanceOf` as safe to call, regardless of initialization Signed the CLA - @Xavientois Review by @liufengyun
Xavientois
force-pushed
the
eq-ne-always-valid-init-check
branch
from
a3c21ae
to
ec794f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14275
ne,eq,isInstanceOf, andasInstanceOfas safeto call, regardless of initialization
Signed the CLA - @Xavientois
Review by @liufengyun