Search all source trees for a given span #14436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgodzik
force-pushed
the
fix-toplevel-enums
branch
from
34df1d2
to
1c0f0de
Compare
tgodzik
changed the title
tgodzik
force-pushed
the
fix-toplevel-enums
branch
from
1c0f0de
to
63379fd
Compare
prolativ
approved these changes
Feb 17, 2022
smarter
approved these changes
Feb 17, 2022
| @@ -72,7 +72,7 @@ object NavigateAST { | |||
| * end point are the same, so this is useful when trying to reconcile | |||
| * nodes with source code. | |||
| */ | |||
| def pathTo(span: Span, from: Positioned, skipZeroExtent: Boolean = false)(using Context): List[Positioned] = { | |||
There was a problem hiding this comment.
The documentation comment above needs to be slightly tweaked: it says "from node from" but I guess now it would be "from any node in from"
There was a problem hiding this comment.
Changed. Good catch!
When we create a synthetic companion object, for exmaple for enums, all the value definitions are put into it and the there are actually multiple trees that contain the position we are itnerested in. Now, NavigateAST.pathTo takes in multiple trees since the method is already able to find the best fit.
tgodzik
force-pushed
the
fix-toplevel-enums
branch
from
55ab0ac
to
f33fcb9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we create a synthetic companion object, for exmaple for enums, all the value definitions are put into it and the there are actually multiple trees that contain the position we are itnerested in.
I decided to check which path is the longest, which most likely is the most exact. I am open to all ideas as I am not sure this is the best solution.Actually, it dawned on me in the morning that there is already a logic for choosing the best tree and it already works fine.Fixes #8738