Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't compute indents when in a string #14441

Merged
merged 1 commit into from Feb 19, 2022
Merged

Don't compute indents when in a string #14441

merged 1 commit into from Feb 19, 2022

Conversation

som-snytt
Copy link
Contributor

Fixes #14386

@mbovel mbovel requested a review from odersky February 11, 2022 12:57
odersky
odersky previously requested changes Feb 11, 2022
View reviewed changes
Copy link
Contributor

@odersky odersky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First commit looks good.

Second commit: I'd hold off on it. I think breaking out small things in inline functions is overblown.

@som-snytt
Copy link
Contributor Author

I'll drop the 2nd commit, which was a finger exercise, as the pianists say.

@smarter smarter dismissed odersky’s stale review February 19, 2022 16:58

Requested changes were implemented.

@smarter smarter merged commit 62d54fe into scala:main Feb 19, 2022
@som-snytt som-snytt deleted the issue/14386 branch February 19, 2022 17:56
@Kordyjan Kordyjan added this to the 3.1.3 milestone Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smarter smarter smarter approved these changes

@odersky odersky odersky left review comments

Assignees

@som-snytt som-snytt

Labels
None yet
Projects
None yet
Milestone
3.1.3
4 participants
@som-snytt @smarter @odersky @Kordyjan