improvement(repl): add in feedback when resetting REPL state #14521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a user I'm a big fan of getting feedback from the tools I'm working with. Without out, you have to go on assumption that what you just tried worked unless it explodes. In Scala 2 when you do a `:reset` in the REPL you get a nice message about it being reset and even some details about what exactly was reset. Following that train of thought this just adds in small note when you reset your session. Here are a couple examples which you can also see in the changed tests: ```none scala>:reset -deprecation Resetting REPL state with the following settings: -deprecation ``` ```none scala>:reset Resetting REPL state. ```
romanowski
approved these changes
Feb 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a user I'm a big fan of getting feedback from the tools I'm working
with. Without out, you have to go on assumption that what you just tried
worked unless it explodes. In Scala 2 when you do a
:resetin the REPLyou get a nice message about it being reset and even some details about
what exactly was reset.
Following that train of thought this just adds in small note when you
reset your session. Here are a couple examples which you can also see in
the changed tests: